Skip to content

[CodeQuality] Skip indirect parent is PHPUnit\Framework\TestCase on NoSetupWithParentCallOverrideRector #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samsonasik wants to merge 7 commits into from
Closed

[CodeQuality] Skip indirect parent is PHPUnit\Framework\TestCase on NoSetupWithParentCallOverrideRector #618

samsonasik wants to merge 7 commits into from

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 27, 2026

Ref #617 (comment)

The indirect should be allowed to be kept, as #[Override] there is override non-empty method from parent of another class that extends PHPUnit\Framework\TestCase

RealTest -> SomeFunctionalTestCase -> PHPUnit\Framework\TestCase

which #[Override] is fine.

@samsonasik samsonasik mentioned this pull request Jan 27, 2026
Merged
@samsonasik
Copy link
Member Author

samsonasik commented Jan 27, 2026

Fixed 🎉 /cc @TomasVotruba , I add TestsNodeAnalyzer::isDirectlyExtendsTestCase() to cover this, so only remove #[Override] when directly extends PHPUnit test case.

@samsonasik
Copy link
Member Author

samsonasik commented Jan 27, 2026

@TomasVotruba ready 👍

@TomasVotruba
Copy link
Member

TomasVotruba commented Jan 27, 2026

Goal of this rule is different.
If there is a parent::setUp() call, it's obviously overrode. That's what this rule looks for

@samsonasik samsonasik deleted the skip-indirect branch January 27, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samsonasik @TomasVotruba @actions-user